Skip to content

Conversation

@GiselleNessi
Copy link
Contributor

@GiselleNessi GiselleNessi commented Apr 24, 2025


PR-Codex overview

This PR updates the page.mdx file in the faq section of the ecosystem wallet documentation, specifically modifying the mention of WalletConnect and clarifying the billing information for Ecosystem Wallets.

Detailed summary

  • Updated the name of WalletConnect to WalletConnect (now Reown) with a link to https://reown.com/.
  • Added a newline at the end of the billing section for better formatting (previously missing).

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@GiselleNessi GiselleNessi self-assigned this Apr 24, 2025
@GiselleNessi GiselleNessi requested review from a team as code owners April 24, 2025 20:42
@changeset-bot
Copy link

changeset-bot bot commented Apr 24, 2025

⚠️ No Changeset found

Latest commit: 68aa693

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 9:05pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) Apr 24, 2025 9:05pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 24, 2025 9:05pm
thirdweb-www ⬜️ Skipped (Inspect) Apr 24, 2025 9:05pm
wallet-ui ⬜️ Skipped (Inspect) Apr 24, 2025 9:05pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 24, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Apr 24, 2025
@GiselleNessi GiselleNessi added DO NOT MERGE This pull request is still in progress and is not ready to be merged. merge-queue Adds the pull request to Graphite's merge queue. labels Apr 24, 2025
Copy link
Contributor Author

GiselleNessi commented Apr 24, 2025

Merge activity

@GiselleNessi GiselleNessi removed the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Apr 24, 2025
@codecov
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.31%. Comparing base (270e53c) to head (68aa693).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6845   +/-   ##
=======================================
  Coverage   55.31%   55.31%           
=======================================
  Files         896      896           
  Lines       57023    57023           
  Branches     3971     3971           
=======================================
  Hits        31541    31541           
  Misses      25385    25385           
  Partials       97       97           
Flag Coverage Δ
packages 55.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 24, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.16 KB (0%) 1.1 s (0%) 106 ms (+200.61% 🔺) 1.2 s
thirdweb (cjs) 143.77 KB (0%) 2.9 s (0%) 174 ms (+70.85% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.66 KB (0%) 114 ms (0%) 46 ms (+2037.17% 🔺) 159 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 17 ms (+1452.91% 🔺) 27 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 68 ms (+866.01% 🔺) 455 ms

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the `page.mdx` file in the `faq` section of the `ecosystem` by modifying the mention of `WalletConnect` to reflect its new branding as `Reown` and clarifying the billing details without altering the content.

### Detailed summary
- Changed the heading from `WalletConnect (Coming Soon)` to `WalletConnect [(now Reown)](https://reown.com/)`.
- No content changes in the billing section, but ensured proper formatting by adding a newline at the end of the file.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the GiselleNessi-patch-1 branch from 45883df to 68aa693 Compare April 24, 2025 21:03
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 24, 2025 21:03 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 24, 2025 21:03 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www April 24, 2025 21:03 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 24, 2025 21:03 Inactive
@graphite-app graphite-app bot merged commit 68aa693 into main Apr 24, 2025
22 checks passed
@graphite-app graphite-app bot deleted the GiselleNessi-patch-1 branch April 24, 2025 21:07
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Apr 24, 2025
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 24, 2025 21:07 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 24, 2025 21:07 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www April 24, 2025 21:07 Inactive
@vercel vercel bot temporarily deployed to Production – login April 24, 2025 21:07 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants